Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【Hackathon 5 No.16】为 Paddle 新增 EmbeddingBag API （WIP） #58027

Closed
wants to merge 39 commits into from
Closed

【Hackathon 5 No.16】为 Paddle 新增 EmbeddingBag API （WIP） #58027

wants to merge 39 commits into from

Conversation

xlcjz
Copy link

@xlcjz xlcjz commented Oct 11, 2023 •
edited
Loading

PR types

New features

PR changes

APIs

Description

RFC
为 Paddle 新增 EmbeddingBag API
WIP:施工中

JianmingGuo and others added 30 commits December 12, 2022 10:53
@JianmingGuo
make the new branch from the develop and transfer my modification
a611cd9
@JianmingGuo
fix the problem of indent
99d481d
@JianmingGuo
fix the problem of gpu build
64b821a
@JianmingGuo
delete the operators/xx and modify the ops.yaml & backward.yaml
50d8421
@JianmingGuo
delete the operators/xx and modify the ops.yaml & backward.yaml
051152a
@JianmingGuo
Merge branch 'develop' into embeddingbag1
4268d82
@JianmingGuo
Merge branch 'PaddlePaddle:develop' into embeddingbag1
d1cfb03
@JianmingGuo
delete the ops/campat/xx.sig to solve the problem of multiple difinition
a70c447
@JianmingGuo
unitest: initializer from fluid.initializer to paddle.nn.initializer
42edc6b
@JianmingGuo
unitest: label from fluid.layers.data to paddle.static.data
038c3a9
@JianmingGuo
unitest: label from fluid.layers.data to paddle.static.data
b1c7f47
@JianmingGuo
update the examples
cc7c380
@JianmingGuo
change the datatype for windows error
86bc1b7
@JianmingGuo
update the static check
d9d2a6e
@JianmingGuo
codestyle check except clang-format
e18a93a
@JianmingGuo
update the static check containing clang-format
f2dd59e
@JianmingGuo
Merge branch 'PaddlePaddle:develop' into embeddingbag1
1bb6818
@JianmingGuo
modify unitests for corverage-CI
3f57c57
@JianmingGuo
Merge branch 'embeddingbag1' of github.com:JianmingGuo/Paddle into em…
76584f8 
…beddingbag1
@JianmingGuo
modify unitests for corverage-CI
6a51a45
@JianmingGuo
modify unitests for corverage-CI
318702f
@JianmingGuo
Merge branch 'PaddlePaddle:develop' into embeddingbag1
53cd75c
@JianmingGuo
initialize params_grad with 0
20c4653
@JianmingGuo
Merge branch 'PaddlePaddle:develop' into embeddingbag1
9fe3724
@JianmingGuo
add op unitest
c2ae8e8
@JianmingGuo
Merge branch 'embeddingbag1' of github.com:JianmingGuo/Paddle into em…
83c1760 
…beddingbag1
@JianmingGuo
fix the problem in windows
17c72a4
@JianmingGuo
fix the problem of unused variables of seq
3ef914c
@JianmingGuo
add comments in embedding_bag_grad_kernel.cu
fbdde28
@xlcjz
Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…
9e4aa94 
… continue-embeddingbag
@paddle-bot
Copy link

paddle-bot bot commented Oct 11, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Oct 11, 2023
@xlcjz xlcjz changed the title WIP: add EmbeddingBag api 【Hackathon 5 No.16】为 Paddle 新增 EmbeddingBag API （WIP） Oct 12, 2023
@Ligoml Ligoml mentioned this pull request Oct 12, 2023
Open
@paddle-ci-bot
Copy link

paddle-ci-bot bot commented Oct 19, 2023

Sorry to inform you that 1798b63's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@paddle-ci-bot Paddle-ci-bot
Copy link

paddle-ci-bot bot commented Nov 12, 2023

Sorry to inform you that dba43b3's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@xlcjz xlcjz force-pushed the continue-embeddingbag branch from dba43b3 to d33024a Compare November 29, 2023 02:18
@xlcjz xlcjz force-pushed the continue-embeddingbag branch from 8f78263 to cc9df1e Compare December 8, 2023 07:11
@luotao1
Copy link
Contributor

luotao1 commented Dec 26, 2023

黑客松第5期已公示名单，感谢参与！

@luotao1 luotao1 closed this Dec 26, 2023
@xlcjz
Copy link
Author

xlcjz commented Dec 26, 2023 •
edited
Loading

黑客松第5期已公示名单，感谢参与！

@luotao1 老师好，请问锁定MR的条件是什么呢，目前进度是算子前向相关已经开发完毕，如果补齐了反向相关代码MR还能合入么

@luotao1
Copy link
Contributor

luotao1 commented Dec 28, 2023

请问锁定MR的条件是什么呢

功能开发完毕（包括前向和反向），大部分CI都过了。剩下一些文档、边界条件的case、review过程中发现的需要改进的地方等。最终以研发的review意见为准。

如果补齐了反向相关代码MR还能合入么

PR可以合入，但拿不到黑客松奖金，可以发快乐开源的礼品（见置顶issue）。

@xlcjz
Copy link
Author

xlcjz commented Dec 28, 2023

请问锁定MR的条件是什么呢

功能开发完毕（包括前向和反向），大部分CI都过了。剩下一些文档、边界条件的case、review过程中发现的需要改进的地方等。最终以研发的review意见为准。

如果补齐了反向相关代码MR还能合入么

PR可以合入，但拿不到黑客松奖金，可以发快乐开源的礼品（见置顶issue）。

了解了，感谢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@luotao1 luotao1

@Charles-hit Charles-hit

Labels
contributor External developers PaddlePaddle Hackathon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xlcjz @luotao1 @Charles-hit @JianmingGuo